feat(autoinstallation): Make the addon version optional#2239
Merged
Conversation
Find the version automatically from the list of available addons. This allows using the same autoinstallation profile for the GA, SP1, SP2, etc... releases.
imobachgs
approved these changes
Apr 1, 2025
| .map(|(id, version, code)| AddonParams { | ||
| id, | ||
| version, | ||
| version: if version.is_empty() { |
Contributor
There was a problem hiding this comment.
This function could be useful in this case. However, it is not included yet.
| .register_addon( | ||
| &addon.id, | ||
| &addon.version, | ||
| &addon.version.clone().unwrap_or_default(), |
Contributor
There was a problem hiding this comment.
Would an empty version work?
Contributor
Author
There was a problem hiding this comment.
Yes, in the end the backend receives empty version because nil cannot be sent over DBus. So omitting the version is the same as using empty string.
And if SCC really uses an empty version then it will work too, just using a slightly more complicated path in the code.
Merged
imobachgs
added a commit
that referenced
this pull request
Apr 22, 2025
Prepare to release Agama 14: * #1994 * #2041 * #2103 * #2178 * #2189 * #2200 * #2205 * #2209 * #2212 * #2213 * #2214 * #2215 * #2216 * #2217 * #2219 * #2220 * #2224 * #2225 * #2226 * #2227 * #2228 * #2230 * #2231 * #2232 * #2233 * #2235 * #2237 * #2239 * #2241 * #2242 * #2244 * #2245 * #2246 * #2247 * #2248 * #2249 * #2250 * #2251 * #2252 * #2253 * #2254 * #2255 * #2256 * #2257 * #2259 * #2260 * #2262 * #2265 * #2266 * #2268 * #2269 * #2271 * #2272 * #2273 * #2275 * #2276 * #2278 * #2281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
{ "id": "sle-ha", "version": "16.0", "registrationCode": "<CODE>" }Solution
{ "id": "sle-ha", "registrationCode": "<CODE>" }idvalue.Notes
Testing